Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

NAS-101531 / 11.3 / Do not test len of None #923

Merged
merged 1 commit into from
May 13, 2019

Conversation

skarekrow
Copy link
Member

NAS-101531

Signed-off-by: Brandon Schneider brandon@ixsystems.com

NAS-101531

Signed-off-by: Brandon Schneider <brandon@ixsystems.com>
@skarekrow skarekrow requested a review from a team April 24, 2019 19:11
@bugclerk bugclerk changed the title Do not test len of None NAS-101531 / 11.3 / Do not test len of None Apr 24, 2019
@skarekrow skarekrow added the backport-11.2 Backport to FreeNAS 11.2 label Apr 24, 2019
@skarekrow skarekrow self-assigned this Apr 24, 2019
@sonicaj
Copy link
Member

sonicaj commented Apr 25, 2019

So i think this requires changes in the jail plugin on FN end as well to ensure that we have defaults for source/destination in case index is specified - also i think we can improve the validation there by ensuring that if index is not provided - we ensure other values are provided for actions other then list.

@skarekrow
Copy link
Member Author

So i think this requires changes in the jail plugin on FN end as well to ensure that we have defaults for source/destination in case index is specified - also i think we can improve the validation there by ensuring that if index is not provided - we ensure other values are provided for actions other then list.

That shouldn't be required as the defaults are handled in the library itself now.

@sonicaj
Copy link
Member

sonicaj commented Apr 25, 2019

Nope - we pass None from FN end - also we don't validate properly the two cases i.e with/without index props

@skarekrow skarekrow merged commit 207e0a6 into iocage:master May 13, 2019
@skarekrow skarekrow deleted the NAS-101531 branch May 13, 2019 21:12
@bugclerk bugclerk added the backported FreeNAS label label May 13, 2019
skarekrow added a commit that referenced this pull request Sep 12, 2020
NAS-101531

Signed-off-by: Brandon Schneider <brandon@ixsystems.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-11.2 Backport to FreeNAS 11.2 backported FreeNAS label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants