Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add "clear console" button to console menu #1015

Closed
teonbrooks opened this issue Oct 4, 2018 · 6 comments
Closed

[Feature Request] add "clear console" button to console menu #1015

teonbrooks opened this issue Oct 4, 2018 · 6 comments

Comments

@teonbrooks
Copy link
Contributor

teonbrooks commented Oct 4, 2018

Was testing some things on extremely-alpha and I noticed a feature that would be nice to have: an ability to clear the console. I don't know if there are system level commands in iodide, but a clear command would be great.

@hamilton
Copy link
Contributor

hamilton commented Oct 4, 2018

big +1 to this idea. I'll assign it to myself. Expect a fix early next week. I would maybe suggest:

1.) an easy api call, like iodide.console.clear which can be entered anywhere (console or within a code chunk),
2.) a button that also calls iodide.console.clear

@teonbrooks
Copy link
Contributor Author

teonbrooks commented Nov 2, 2018

yay, thanks @mdboom and @hamilton! 🎉

@bcolloran bcolloran reopened this May 13, 2019
@bcolloran bcolloran changed the title [Feature Request] clear console [Feature Request] add "clear console" button to console menu May 13, 2019
@imranariffin
Copy link
Collaborator

imranariffin commented Nov 18, 2019

After discussion with @wlach during Pycon 2019 Sprint it appears this issue was already worked on and merged by PR #1119 but later reverted, the labels "help wanted" and "good first issue" should probably be removed.

@bcolloran
Copy link
Contributor

@imranariffin thanks for the comment! i think this probably is a still a good first issue, as the scope has changed since the original implementation about a year ago -- there is now a menu component in the console, and this issue would just require the addition of a entry in that menu that clears the evaluation history in the redux store, which should be pretty simple. It would just be:

languages (js, python, etc)
-------(divder)
clear evaluation history

the hardest part will probably be figuring out the right way to add divider to the menu...

cc @wlach

@wlach
Copy link
Contributor

wlach commented Nov 18, 2019

@bcolloran makes sense to me! @imranariffin -- let me know if you're interested in working on this afterwards.

@imranariffin
Copy link
Collaborator

If @wlach I'm really happy to pick up this one afterwards, but first let's see how well I do on my current issue #2445 xD

bcolloran pushed a commit that referenced this issue Nov 19, 2019
* Display clear console dropdown item with icon

* Define reducer to clear history on CLEAR action

* Dispatch console/history/CLEAR action on click

* Delint

* Enable clear console only when history not empty

* Add unit test for clear console action onClick behaviour

* Make test spacing style consistent

* Update changelog

* Remove unnecessary console entries in test

* Fix typo in test name
@teonbrooks teonbrooks closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants