Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as a user, I would like a toolbar of some sort on the console #1090

Closed
hamilton opened this issue Oct 23, 2018 · 5 comments
Closed

as a user, I would like a toolbar of some sort on the console #1090

hamilton opened this issue Oct 23, 2018 · 5 comments
Assignees
Labels

Comments

@hamilton
Copy link
Contributor

hamilton commented Oct 23, 2018

Working with the console over a long period of time becomes pretty difficult. One way we can manage volume would be to:

  • have a clear console button ([Feature Request] add "clear console" button to console menu #1015). This should probably not clear the history stored in redux - I can see that still being relevant for forensics even when the console is very long. Could be wrong about that though.
  • have a button that lets me hide the code inputs from the console, since these are one of the largest contributors to the console right now.
  • have a button that lets me hide the code outputs. Could be different output types you can hide, or console levels (show only info / warning / error / debug / etc)
@bcolloran
Copy link
Contributor

after dogfooding this a bit, i think this should be in a menu that lives in the right hand side of the console text entry rather than a toolbar -- the tool bar just eats up a lot of our precious screen real estate for three buttons (and just one ATM)

also, I'm seeing rendering errors with the clear button on extremely-alpha and localhost with both FF and Chrome.

image
i'm going to take a pass at all this

@hamilton
Copy link
Contributor Author

hamilton commented Nov 6, 2018 via email

@bcolloran
Copy link
Contributor

sgtm -- in the meantime, since this feature is not working as expected and we're not sure about the UX we want, and a couple code quality things got past review, i've reverted #1119. we can take another crack after discussing :-)

@hamilton
Copy link
Contributor Author

hamilton commented Nov 6, 2018

Sounds good to me. fwiw I believe that issue you're encountering was brought up in that PR, which had a fix & review on my mbp on FF. Clearly I didn't do a good enough code review on this pass - apologies!

Also will do a better job in the future checking on Chrome.

@bcolloran
Copy link
Contributor

menu exists, reopened #1015 to add a "clear console" button back in that menu. closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants