-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as a user, I would like a toolbar of some sort on the console #1090
Comments
after dogfooding this a bit, i think this should be in a menu that lives in the right hand side of the console text entry rather than a toolbar -- the tool bar just eats up a lot of our precious screen real estate for three buttons (and just one ATM) also, I'm seeing rendering errors with the clear button on extremely-alpha and localhost with both FF and Chrome. |
Let’s talk about this during tomorrow’s standup before going forward with a
change.
…On Mon, Nov 5, 2018 at 4:40 PM bcolloran ***@***.***> wrote:
after dogfooding this a bit, i think this should be in a menu that lives
in the right hand side of the console text entry rather than a toolbar --
the tool bar just eats up a lot of our precious screen real estate for
three buttons (and just one ATM)
also, I'm seeing rendering errors with the clear button on extremely-alpha
and localhost with both FF and Chrome.
[image: image]
<https://user-images.githubusercontent.com/2380975/48035454-e7400f80-e118-11e8-958d-94e905b3f84e.png>
i'm going to take a pass at all this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1090 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF192i6h1PKBMpvxtuPl4SQPVlMvZ9zks5usNpzgaJpZM4X0qIz>
.
|
sgtm -- in the meantime, since this feature is not working as expected and we're not sure about the UX we want, and a couple code quality things got past review, i've reverted #1119. we can take another crack after discussing :-) |
Sounds good to me. fwiw I believe that issue you're encountering was brought up in that PR, which had a fix & review on my mbp on FF. Clearly I didn't do a good enough code review on this pass - apologies! Also will do a better job in the future checking on Chrome. |
menu exists, reopened #1015 to add a "clear console" button back in that menu. closing this one |
Working with the console over a long period of time becomes pretty difficult. One way we can manage volume would be to:
The text was updated successfully, but these errors were encountered: