fs: ensure nullCheck() callback is a function #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,10 @@ assert.throws(function() { | |||
| fs.access(__filename, fs.F_OK); | |||
| }, /callback must be a function/); | |||
|
|
|||
| assert.throws(function() { | |||
| fs.access('foo\u0000bar', fs.F_OK, {}); | |||
| }, /callback must be a function/); | |||
There was a problem hiding this comment.
test/parallel/test-fs-null-bytes.js is arguably a better place for this but I'll leave that up to you.
|
LGTM with a suggestion. |
Currently, nullCheck() will attempt to invoke any truthy value as a function if the path argument contains a null character. This commit validates that the callback is actually a function before trying to invoke it. fs.access() was vulnerable to this bug, as nullCheck() was called prior to type checking its callback.
cjihrig
added a commit
that referenced
this pull request
Feb 19, 2015
Currently, nullCheck() will attempt to invoke any truthy value as a function if the path argument contains a null character. This commit validates that the callback is actually a function before trying to invoke it. fs.access() was vulnerable to this bug, as nullCheck() was called prior to type checking its callback. PR-URL: #887 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Incorporated feedback and landed in ecef871. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
nullCheck()will attempt to invoke any truthy value as a function if thepathargument contains a null character. This commit validates that the callback is actually a function before trying to invoke it.fs.access()was vulnerable to this bug, asnullCheck()was called prior to type checking itscallback.