Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra parentheses with spec test #490

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 19, 2023

resolves #489

There was an extra set of parentheses that was causing tests to fail on a syntax error.

Error: src/app/pages/home/home.page.spec.ts:8:14 - error TS2304: Cannot find name 'async'.

8   beforeEach(async(() => {
               ~~~~~

This was probably left over from our previous waitForAsync usage which was a function call:

@liamdebeasi liamdebeasi marked this pull request as ready for review May 19, 2023 13:30
@liamdebeasi liamdebeasi merged commit 87b1018 into main May 22, 2023
2 checks passed
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-1 branch May 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Ionic v7 spec file from page generated by cli: Cannot find name 'async'.
2 participants