bug: Ionic v7 spec file from page generated by cli: Cannot find name 'async'.

[jsnimda]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

v7.x

Current Behavior

TypeScript problems found in spec file, which is from page generated by ionic cli. It reports "Cannot find name 'async'."

Expected Behavior

No problems found

Steps to Reproduce

1. ionic start photo-gallery tabs --type=angular --capacitor
2. ionic g page pages/home
3. open src/app/pages/home/home.page.spec.ts in vscode

>  beforeEach(async(() => {
              ~~~~~
>    fixture = TestBed.createComponent(HomePage);
>    component = fixture.componentInstance;
>    fixture.detectChanges();
>  }));

4. problems found in above code

Code Reproduction URL

No response

Ionic Info

Ionic:

   Ionic CLI                     : 7.1.1 
   Ionic Framework               : @ionic/angular 7.0.7
   @angular-devkit/build-angular : 16.0.2
   @angular-devkit/schematics    : 16.0.2
   @angular/cli                  : 16.0.2
   @ionic/angular-toolkit        : 9.0.0

Capacitor:

   Capacitor CLI      : 5.0.3
   @capacitor/android : not installed
   @capacitor/core    : 5.0.3
   @capacitor/ios     : not installed

Utility:

   cordova-res : not installed globally
   native-run  : 1.7.2

System:

   NodeJS : v16.14.0 
   npm    : 8.3.1
   OS     : macOS Unknown

Additional Information

Ionic v6 generate page use waitForAsync instead of async.
Ionic v7 generate component also use waitForAsync
Old related changes: ionic-team/ionic-framework#22154

[liamdebeasi]

Thanks! I fixed this in #490. The fix should be available in an upcoming release of @ionic/angular-toolkit.

[LucasHayashi]

The Ionic 7.2 version still has a bug that adds an extra parenthesis in the test file.

How to reproduce:

ionic generate page test

This results in the following TypeScript compiler error:

Cannot find name 'async'.ts(2304)

beforeEach(async(() => {
  fixture = TestBed.createComponent(TopicsPage);
  component = fixture.componentInstance;
  fixture.detectChanges();
}));

[liamdebeasi]

The bug was in @ionic/angular-toolkit, not @ionic/angular. You'll want to make sure @ionic/angular-toolkit is updated to receive this bug fix.