fix(push-notifications): Throw errors if missing mandatory channel fi…

…elds (#576)
ionic-team · Aug 30, 2021 · 50f4e70 · 50f4e70
1 parent 6bf3a4f
commit 50f4e70
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/...d/src/main/java/com/capacitorjs/plugins/pushnotifications/NotificationChannelManager.java b/...d/src/main/java/com/capacitorjs/plugins/pushnotifications/NotificationChannelManager.java
@@ -38,11 +38,26 @@ public NotificationChannelManager(Context context, NotificationManager manager)
     public void createChannel(PluginCall call) {
         if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.O) {
             JSObject channel = new JSObject();
-            channel.put(CHANNEL_ID, call.getString(CHANNEL_ID));
-            channel.put(CHANNEL_NAME, call.getString(CHANNEL_NAME));
+            if (call.getString(CHANNEL_ID) != null) {
+                channel.put(CHANNEL_ID, call.getString(CHANNEL_ID));
+            } else {
+                call.reject("Channel missing identifier");
+                return;
+            }
+            if (call.getString(CHANNEL_NAME) != null) {
+                channel.put(CHANNEL_NAME, call.getString(CHANNEL_NAME));
+            } else {
+                call.reject("Channel missing name");
+                return;
+            }
+            if (call.getInt(CHANNEL_IMPORTANCE) != null) {
+                channel.put(CHANNEL_IMPORTANCE, call.getInt(CHANNEL_IMPORTANCE));
+            } else {
+                call.reject("Channel missing importance");
+                return;
+            }
             channel.put(CHANNEL_DESCRIPTION, call.getString(CHANNEL_DESCRIPTION, ""));
             channel.put(CHANNEL_VISIBILITY, call.getInt(CHANNEL_VISIBILITY, NotificationCompat.VISIBILITY_PUBLIC));
-            channel.put(CHANNEL_IMPORTANCE, call.getInt(CHANNEL_IMPORTANCE));
             channel.put(CHANNEL_SOUND, call.getString(CHANNEL_SOUND, null));
             channel.put(CHANNEL_VIBRATE, call.getBoolean(CHANNEL_VIBRATE, false));
             channel.put(CHANNEL_USE_LIGHTS, call.getBoolean(CHANNEL_USE_LIGHTS, false));