Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push-notification): Notification not dispatching click when received in foreground #1629

Closed
wants to merge 1 commit into from

Conversation

AndrewKravchenko
Copy link

Based on #1478

Added generateUniqueId method to prevent overwriting the last notification

@tafelnl
Copy link
Contributor

tafelnl commented Jun 7, 2023

I think you've got more chance of getting this merged, if you only make this about the uniqueId part. PRs should be as small as possible, and with the smallest scope possible. The other PR you mentioned will then be solely about the click-dispatch thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants