fix(android): resolve undefined for both checkPermissions and request…

…Permissions by default (#3855)
ionic-team · Nov 24, 2020 · 383f62b · 383f62b
1 parent f403790
commit 383f62b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/Plugin.java b/android/capacitor/src/main/java/com/getcapacitor/Plugin.java
@@ -264,7 +264,13 @@ public boolean hasRequiredPermissions() {
     @PluginMethod
     public void checkPermissions(PluginCall pluginCall) {
         JSObject permissionsResult = getPermissionStates();
-        pluginCall.resolve(permissionsResult);
+
+        if (permissionsResult.length() == 0) {
+            // if no permissions are defined on the plugin, resolve undefined
+            pluginCall.resolve();
+        } else {
+            pluginCall.resolve(permissionsResult);
+        }
     }
 
     /**
@@ -561,6 +567,7 @@ public void requestPermissions(PluginCall call) {
 
                 call.resolve(permissionsResults);
             } else {
+                // no permissions are defined on the plugin, resolve undefined
                 call.resolve();
             }
         }