Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First go checklist #82

Closed
7 tasks done
mlynch opened this issue Jan 23, 2018 · 9 comments
Closed
7 tasks done

First go checklist #82

mlynch opened this issue Jan 23, 2018 · 9 comments
Assignees

Comments

@mlynch
Copy link
Contributor

mlynch commented Jan 23, 2018

  • capacitor update clean requirement for iOS? (needed to clean in Xcode before build would succeed) @jcesarmobile
  • Make sure native-bridge.js gets copied with capacitor copy OR with installing the core command
  • Can we use relative paths for capacitor update for pod files to node_modules, instead of the absolute path? @jcesarmobile
  • Improve the pod deploy script to avoid the nasty github tag. Can we use lerna?
  • Cli shouldn't use Capacitor pod from assets
  • Note about pod repo update
  • Ship android dependency and add update feature to cli
@mlynch
Copy link
Contributor Author

mlynch commented Jan 23, 2018

I removed the old temporary hacks for local cocoapods stuff and tested a working app start to finish

@jcesarmobile
Copy link
Member

Improve the pod deploy script to avoid the nasty github tag. Can we use lerna?

For the podspec's source we can use a git tag, branch or commit, or use http to a zip, tgz, bz2, txz or tar file. We could create a script that zips the code and uploads it somewhere always with the same name, but then every app that uses Capacitor will download that zip and use a lot of our bandwidth

@mlynch
Copy link
Contributor Author

mlynch commented Jan 23, 2018

@jcesarmobile I mean the tag system for git that cocapods uses for versions. You have to push a tag, say 0.0.9, and then tell cocoapods to update trunk. I'd love for lerna to keep each version locked and do publishes for us

@jcesarmobile
Copy link
Member

What I mean is, it uses tags because we specified a tag in the podspec, we can use a branch, commit or zipped file instead by changing the source param

@mlynch
Copy link
Contributor Author

mlynch commented Jan 23, 2018

I see. I think the tags work but they need to be synced with whatever lerna is doing.

mlynch added a commit that referenced this issue Jan 23, 2018
@mlynch
Copy link
Contributor Author

mlynch commented Jan 23, 2018

#84 merged

@mlynch
Copy link
Contributor Author

mlynch commented Jan 23, 2018

#85 merged to add clean

@mlynch
Copy link
Contributor Author

mlynch commented Jan 24, 2018

I started setting up bintray for Android, following what I'm seeing with other libraries like realm: https://bintray.com/realm/maven/realm-gradle-plugin/4.3.3

Instructions on installing realm just to compare https://realm.io/docs/java/latest

@mlynch
Copy link
Contributor Author

mlynch commented Feb 5, 2018

We went live for the first go! It was rocky but we got it done 🤙 🏄

@mlynch mlynch closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants