Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron-template): update @capacitor/electron dependency to use final version #1630

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(electron-template): update @capacitor/electron dependency to use final version #1630

merged 1 commit into from
Jun 4, 2019

Conversation

tmpreston
Copy link
Contributor

No description provided.

jcesarmobile
jcesarmobile approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think proper fix would be to make the CLI install @capacitor/electron same way it does it for @capacitor/ios and @capacitor/android, so we don't have to update the package.json in future updates.

But will merge for now. Thanks for the PR!

@jcesarmobile jcesarmobile changed the title Package.json still pointing to electron alpha version fix(electron): Package.json still pointing to electron alpha version Jun 4, 2019
@jcesarmobile jcesarmobile changed the title fix(electron): Package.json still pointing to electron alpha version fix(electron-template): update @capacitor/electron dependency to use final version Jun 4, 2019
@jcesarmobile jcesarmobile merged commit 1c10d0d into ionic-team:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmpreston @jcesarmobile