-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): implement BridgeFragment for easier embedding using Fragments #2666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing because you are not using Fragment from Android X (androidx.fragment.app.Fragment
).
Check the mappings for some other files here https://developer.android.com/jetpack/androidx/migrate/class-mappings
Ah good catch. Fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few comments
android/capacitor/src/main/java/com/getcapacitor/BridgeFragment.java
Outdated
Show resolved
Hide resolved
android/capacitor/src/main/java/com/getcapacitor/BridgeFragment.java
Outdated
Show resolved
Hide resolved
k cleaned it up and squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a few small changes, looks good to me
No description provided.