-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support TS/JS config files #3756
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
afb21ad
feat(cli): STUDIO_PATH environment variable
imhoffd e1e7f66
check before opening
imhoffd cf26a4b
use config for config file name
imhoffd c96aa18
split out extConfig stuff
imhoffd d541287
load js
imhoffd 7d0e5c1
copy = write json from loaded config
imhoffd 8a47e91
init for non-json
imhoffd 5e98605
Merge branch 'main' into dynamic-config
imhoffd 76264f2
revert the help output
imhoffd 9462e6a
support TS files
imhoffd 859c0ef
expose CapacitorConfig type
imhoffd c2eb9c3
internalize readonly
imhoffd 7861b80
document all the things
imhoffd 4b3b2bd
undo core change
imhoffd 99d9206
Merge branch 'main' into dynamic-config
imhoffd ed8d1fa
Merge branch 'main' into dynamic-config
imhoffd 859ed8a
use accurate versions for since tags
imhoffd 22b9138
small typo
imhoffd 5cbc24d
document scrollEnabled
imhoffd a50c492
reword bundle option
imhoffd f74789f
clarify default option on allowsLinkPreview
imhoffd 2473a48
app id
imhoffd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be quite useful to optionally support exporting a
() => Promise<ExternalConfig>
instead of justExternalConfig
.Would you accept a pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking about this as well. I would be happy to look at a PR that adds that functionality.