Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): Use plugin's getPermissionStates() to support overriding #3939

Merged
merged 3 commits into from
Dec 13, 2020

Conversation

carlpoole
Copy link
Member

Ensures that the getPermissionStates method is called against the Plugin in case a plugin author has override it to manipulate the states.

Alternative to: #3911

@carlpoole carlpoole added this to the 3.0.0 milestone Dec 11, 2020
@carlpoole carlpoole self-assigned this Dec 11, 2020
@carlpoole carlpoole added this to In progress 🤺 in Capacitor Engineering ⚡️ via automation Dec 11, 2020
@carlpoole carlpoole changed the title fix(Android): Use plugin getPermissionStates in case it is overridden fix(Android): Use plugin getPermissionStates method in case it is overridden Dec 11, 2020
@ikeith ikeith mentioned this pull request Dec 11, 2020
5 tasks
@imhoffd imhoffd changed the title fix(Android): Use plugin getPermissionStates method in case it is overridden fix(Android): Use plugin's getPermissionStates() to support overriding Dec 13, 2020
@imhoffd imhoffd merged commit 855a607 into main Dec 13, 2020
Capacitor Engineering ⚡️ automation moved this from In progress 🤺 to Done 🎉 Dec 13, 2020
@imhoffd imhoffd deleted the perm-states branch December 13, 2020 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants