Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): Provide override hook for permissions #3911

Closed
wants to merge 4 commits into from
Closed

Conversation

ikeith
Copy link
Contributor

@ikeith ikeith commented Dec 8, 2020

This branch changes the automatic permission handling on android to let Plugins provide an override state at runtime. This is needed in the case of the Camera plugin to conditionally skip the camera permissions depending on the contents of the manifest.

Draft pending testing.

@imhoffd
Copy link
Contributor

imhoffd commented Dec 8, 2020

I have to ask the question now before we enter beta: Are we trying to do too much on Android for permissions? Should we roll back the implicit behavior and instead just define a contract: the Plugin class would have requestPermissions and checkPermissions, but they'd run call.unimplemented() unless overridden. We could define helpers to mitigate the implementation details for the plugin author.

@ikeith ikeith marked this pull request as ready for review December 9, 2020 19:23
@ikeith ikeith mentioned this pull request Dec 9, 2020
5 tasks
@imhoffd
Copy link
Contributor

imhoffd commented Dec 11, 2020

To get Camera functional for beta, LGTM

I think we should circle back and reevaluate, though.

@ikeith
Copy link
Contributor Author

ikeith commented Dec 11, 2020

Closing in preference of #3939

@ikeith ikeith closed this Dec 11, 2020
@imhoffd imhoffd deleted the permissions branch December 11, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants