Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): Add URLSearchParams support #7040

Closed
wants to merge 1 commit into from
Closed

fix(http): Add URLSearchParams support #7040

wants to merge 1 commit into from

Conversation

philjones88
Copy link
Contributor

fixes #7032

@philjones88
Copy link
Contributor Author

Anyone? Contributions not welcome?

@ItsChaceD ItsChaceD self-requested a review January 17, 2024 12:55
ItsChaceD
ItsChaceD approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ItsChaceD ItsChaceD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ItsChaceD ItsChaceD changed the title Add URLSearchParams support to Capacitor Http fix(http): Add URLSearchParams support Jan 17, 2024
@philjones88
Copy link
Contributor Author

@ItsChaceD thanks. do i need to try and do a v6 version?

@mr-matt-b mr-matt-b mentioned this pull request Feb 29, 2024
Closed
@mr-matt-b
Copy link

@ItsChaceD Can we get this merged please?

I've created another PR with these same changes for v6 if that was the blocking factor.

@jcesarmobile jcesarmobile changed the base branch from 5.x to main March 15, 2024 18:23
@jcesarmobile jcesarmobile changed the base branch from main to 5.x March 15, 2024 18:23
@jcesarmobile
Copy link
Member

Can you send it to main branch instead of to 5.x?

We cherry-pick main changes into 5.x after they get merged.

@DellanX
Copy link

DellanX commented Mar 29, 2024

Any movement on here? Parts of my Auth Flow are blocked by this issue, so I am definitely in need of this.

As always, I am willing to help as well.

@jcesarmobile jcesarmobile mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsChaceD ItsChaceD ItsChaceD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@philjones88 @mr-matt-b @jcesarmobile @DellanX @ItsChaceD