Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): check if urlSchemeTask is stopped before calling its methods #7482

Merged
merged 2 commits into from
May 23, 2024

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented May 23, 2024

add an extension to see if the urlSchemeTask was stopped and check it before calling its methods as they crash if the urlSchemeTask is stopped

closes #7478
closes #7404
closes #7453
closes #7460

Copy link
Member

@Steven0351 Steven0351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense and I like it.

@jcesarmobile jcesarmobile changed the title RDMR-100 fix(ios): check if urlSchemeTask is stopped before calling its methods May 23, 2024
Copy link
Contributor

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is the way.

@jcesarmobile jcesarmobile merged commit b32b5b1 into main May 23, 2024
6 checks passed
@jcesarmobile jcesarmobile deleted the RDMR-100-5 branch May 23, 2024 16:59
@cumhur-guner-deel
Copy link

Is it already available in the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: iOS crash in Http Plugin
4 participants