Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iOS): Don't force "UIScrollViewContentInsetAdjustmentNever" (2.x) #530

Closed
wants to merge 1 commit into from
Closed

feat(iOS): Don't force "UIScrollViewContentInsetAdjustmentNever" (2.x) #530

wants to merge 1 commit into from

Commits on Mar 23, 2020

  1. Don't force "UIScrollViewContentInsetAdjustmentNever". 

    This denies users control.
- Remove both methods that force "UIScrollViewContentInsetAdjustmentNever".
- See @dpogue's comments for reasoning: apache/cordova-plugin-wkwebview-engine#108
- Added some documentation that helps users configure their view properly for devices that have safe-insets due to "the notch" like iPhone X.  (So that they can acheive the same behavior as this change was doing if desired).
See PR ionic-team#530 for details
    @Lindsay-Needs-Sleep
    Lindsay-Needs-Sleep committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    a08540d View commit details
    Browse the repository at this point in the history