Skip to content

Commit

Permalink
target es5 for older android device support
Browse files Browse the repository at this point in the history
  • Loading branch information
nphyatt committed Aug 23, 2018
1 parent 338fa89 commit d0c67cf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
"noUnusedLocals": true,
"pretty": true,
"strict": true,
"target": "es6",
"target": "es5",
"lib": [
"es2016",
"es2015",
"dom"
]
},
Expand Down
4 changes: 3 additions & 1 deletion www/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,9 @@ class IonicDeploy implements IDeployPluginAPI {
// Only initialize start the plugin if fetch is available
if (!this.fetchIsAvailable) {
console.warn('Fetch is unavailable so cordova-plugin-ionic has been disabled.');
await (await this.delegate).hideSplash();
await new Promise<string>( (resolve, reject) => {
cordova.exec(resolve, reject, 'IonicCordovaCommon', 'clearSplashFlag');
});
} else {
await delegate._handleInitialPreferenceState();
}
Expand Down
2 changes: 1 addition & 1 deletion www/guards.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export function isPluginConfig(o: object): o is ISavedPreferences {
const allowedKeys = ['appId', 'channel', 'debug', 'host'];
if (!obj) return false;
for (const key in obj) {
if (!allowedKeys.includes(key)) return false;
if (allowedKeys.indexOf(key) === -1) return false;
}
return obj &&
(obj.appId === undefined || typeof obj.appId === 'string') &&
Expand Down

0 comments on commit d0c67cf

Please sign in to comment.