fix(cordova): load config.xml after serve/build hooks

fixes #4579
ionic-team · Oct 12, 2020 · 9867ada · 9867ada
1 parent e243357
commit 9867ada
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/@ionic/cli/src/commands/cordova/run.ts b/packages/@ionic/cli/src/commands/cordova/run.ts
@@ -255,7 +255,6 @@ Just like with ${input('ionic cordova build')}, you can pass additional options
 
   protected async runServeDeploy(inputs: CommandLineInputs, options: CommandLineOptions): Promise<void> {
     const { loadCordovaConfig } = await import('../../lib/integrations/cordova/config');
-    const conf = await loadCordovaConfig(this.integration);
     const metadata = await this.getMetadata();
 
     if (!this.project) {
@@ -283,6 +282,8 @@ Just like with ${input('ionic cordova build')}, you can pass additional options
       serverUrl = `${details.protocol || 'http'}://${details.externalAddress}:${details.port}`;
     }
 
+    const conf = await loadCordovaConfig(this.integration);
+
     onBeforeExit(async () => {
       conf.resetContentSrc();
       await conf.save();
@@ -313,7 +314,6 @@ Just like with ${input('ionic cordova build')}, you can pass additional options
 
   protected async runBuildDeploy(inputs: CommandLineInputs, options: CommandLineOptions): Promise<void> {
     const { loadCordovaConfig } = await import('../../lib/integrations/cordova/config');
-    const conf = await loadCordovaConfig(this.integration);
     const metadata = await this.getMetadata();
 
     if (!this.project) {
@@ -335,6 +335,7 @@ Just like with ${input('ionic cordova build')}, you can pass additional options
     }
 
     if (options['native-run']) {
+      const conf = await loadCordovaConfig(this.integration);
       const [ platform ] = inputs;
 
       await this.runCordova(filterArgumentsForCordova({ ...metadata, name: 'build' }, options), { stdio: 'inherit' });