Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for dismissOnPageChange should propose a viable alternative #846

Open
AndrWeisR opened this issue Jul 25, 2019 · 0 comments
Labels
triage New issues

Comments

@AndrWeisR
Copy link

URL
https://github.com/ionic-team/ionic/blob/master/angular/BREAKING.md#overlays

What is missing or inaccurate about the content on this page?
The doc says that as a workaround for the removed dismissOnPageChange, there are global events (ionNavWillChange, ionNavDidChange) that you can listen to in order to detect when navigation occurs.

I can't find any documentation anywhere on how to actually use ionNavDidChange, so this is not a great proposed alternative.

I managed to get it working using this code in app.component.ts to subscribe to Angular router events:

router.events.subscribe(event => {
  if (event instanceof NavigationEnd) {
    // Do something
  }
});

Perhaps this should be documented as an alternative to dismissOnPageChange.

@AndrWeisR AndrWeisR added the content Issues related to the contents of the documentation website label Jul 25, 2019
@dotNetkow dotNetkow added the package: angular Issues related to the Ionic Angular documentation label Feb 13, 2020
@liamdebeasi liamdebeasi added triage New issues and removed content Issues related to the contents of the documentation website package: angular Issues related to the Ionic Angular documentation labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issues
Projects
None yet
Development

No branches or pull requests

3 participants