docs(picker): new documentation pages for picker and picker-legacy #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
requested review from
liamdebeasi and
a team
and removed request for
a team
liamdebeasi
suggested changes
Dec 13, 2023
|
|
||
| <body> | ||
| <ion-app> | ||
| <ion-content> |
There was a problem hiding this comment.
Optional, but I think the following demo looks a bit nicer:
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Picker | Basic</title>
<link rel="stylesheet" href="../../../common.css" />
<script src="../../../common.js"></script>
<script
type="module"
src="https://cdn.jsdelivr.net/npm/@ionic/core@7.5.8-dev.11702398696.1ab62ea9/dist/ionic/ionic.esm.js"
></script>
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/@ionic/core@7.5.8-dev.11702398696.1ab62ea9/css/ionic.bundle.css"
/>
<style>
ion-modal {
--height: auto;
align-items: end;
}
ion-picker {
margin-bottom: var(--ion-safe-area-bottom);
}
</style>
</head>
<body>
<ion-app>
<ion-content>
<div class="container">
<ion-button id="open-modal">Open modal</ion-button>
<ion-modal trigger="open-modal" is-open="true">
<ion-toolbar>
<ion-buttons slot="start">
<ion-button onclick="modal.dismiss(null, 'cancel')">Cancel</ion-button>
</ion-buttons>
<ion-buttons slot="end">
<ion-button onclick="modal.dismiss(currentValue, 'confirm')">Done</ion-button>
</ion-buttons>
</ion-toolbar>
<ion-picker>
<ion-picker-column value="javascript">
<ion-picker-column-option value="" disabled="true">--</ion-picker-column-option>
<ion-picker-column-option value="javascript">Javascript</ion-picker-column-option>
<ion-picker-column-option value="typescript">Typescript</ion-picker-column-option>
<ion-picker-column-option value="rust">Rust</ion-picker-column-option>
<ion-picker-column-option value="c#">C#</ion-picker-column-option>
</ion-picker-column>
</ion-picker>
</ion-modal>
</div>
</ion-content>
</ion-app>
<script>
const modal = document.querySelector('ion-modal');
let currentValue = 'javascript';
modal.addEventListener('didDismiss', (event) => {
console.log('didDismiss', JSON.stringify(event.detail));
});
const pickerColumn = document.querySelector('ion-picker-column');
pickerColumn.addEventListener('ionChange', (event) => {
currentValue = event.detail.value;
});
</script>
</body>
</html>Notable changes:
- Add bottom margin to the picker for safe area
- Used the "custom dialog" feature for modal to make the modal only as large as the content
- Removed the "initial-breakpoint" usage (I think this was left over from a previous attempt at using a sheet)
- Updated the modal style to align the modal to the bottom of the view
There was a problem hiding this comment.
Love it! Addressed here: 789540d
liamdebeasi
approved these changes
Dec 13, 2023
static/usage/v8/picker/theming/css-properties/angular/example_component_css.md
Outdated
Show resolved
Hide resolved
liamdebeasi
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the feature work here: ionic-team/ionic-framework#28689
What Changed
ion-pickerwas moved toion-picker-legacy.ion-picker.ion-picker-internalcomponent has a new docs page ation-picker.ion-picker.ion-pickerion-picker-column-optionto customize the appearance.ion-pickerin an overlay. Demonstrates how to pass the selected data back to the presenting component.Resources
New
ion-pickerdocs: https://ionic-docs-git-sp-fw-5583-ionic1.vercel.app/docs/v8/api/pickerLegacy
ion-picker-legacydocs: https://ionic-docs-git-sp-fw-5583-ionic1.vercel.app/docs/v8/api/picker-legacy