-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(playwright): combine test configs for themes and modes (#29206)
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Developers are not able to easily add the "ionic" theme to existing test cases, without running the test against both iOS and MD mode: ```ts configs({ themes: ['ios', 'md', 'ionic'] }) // Generates 4 test cases // - iOS theme on iOS mode // - MD theme on MD mode // - Ionic theme on iOS mode // - Ionic theme on MD mode ``` With the separation of `mode` into look and feel, the majority of test cases do not require testing the mode behavior and instead only need to test the visual theme that is applied to the component. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removes the `themes` option from the `configs` test generator object. ```ts configs({ modes: ['ios', 'md', 'ionic-md'] }) ``` - Combines `theme` and `mode` into the existing `modes` test generator object - The new options are `ionic-ios` and `ionic-md`, to run the Ionic theme against the respective mode. - This path was preferred to avoid deprecating and migrating all existing tests. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> I do not have a strong preference on the semantics of `ionic-ios` vs. `ios-ionic` (theme first vs. mode first). If anyone has an opinion or alternative suggestion, please add a comment. --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
- Loading branch information
1 parent
6d6fd4a
commit 5234224
Showing
4 changed files
with
64 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters