Skip to content

Commit

Permalink
fix(reorder-group): revert item to original position when passing fal…
Browse files Browse the repository at this point in the history
…se to complete (#21396)

fixes #19128
  • Loading branch information
tnc1997 committed May 29, 2020
1 parent 882f8fe commit 5f2001c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/components/reorder-group/reorder-group.tsx
Expand Up @@ -219,7 +219,7 @@ export class ReorderGroup implements ComponentInterface {
const toIndex = this.lastToIndex;
const fromIndex = indexForItem(selectedItemEl);

if (toIndex !== fromIndex && (!listOrReorder || listOrReorder === true)) {
if (toIndex !== fromIndex && (listOrReorder === undefined || listOrReorder === true)) {
const ref = (fromIndex < toIndex)
? children[toIndex + 1]
: children[toIndex];
Expand Down

0 comments on commit 5f2001c

Please sign in to comment.