refactor: use shape=“round” instead

ionic-team · Mar 21, 2024 · 6352186 · 6352186
1 parent e7248cf
commit 6352186
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/core/api.txt b/core/api.txt
@@ -612,7 +612,6 @@ ion-input-password-toggle,prop,color,"danger" | "dark" | "light" | "medium" | "p
 ion-input-password-toggle,prop,hideIcon,string | undefined,undefined,false,false
 ion-input-password-toggle,prop,mode,"ios" | "md",undefined,false,false
 ion-input-password-toggle,prop,showIcon,string | undefined,undefined,false,false
-ion-input-password-toggle,part,button
 
 ion-item,shadow
 ion-item,prop,button,boolean,false,false,false

diff --git a/core/src/components/input-password-toggle/input-password-toggle.tsx b/core/src/components/input-password-toggle/input-password-toggle.tsx
@@ -121,15 +121,11 @@ export class InputPasswordToggle implements ComponentInterface {
           [mode]: true,
         })}
       >
-        {/*
-          This part is intentionally undocumented. It only exists so that Input
-          can style the button when InputPasswordToggle is slotted inside of the Input.
-        */}
         <ion-button
-          part="button"
           mode={mode}
           color={color}
           fill="clear"
+          shape="round"
           aria-checked={isPasswordVisible ? 'true' : 'false'}
           aria-label="show password"
           role="switch"

diff --git a/core/src/components/input/input.ios.scss b/core/src/components/input/input.ios.scss
@@ -35,8 +35,7 @@
  * don't look too crowded.
  */
 ::slotted(ion-button[slot="start"].button-has-icon-only),
-::slotted(ion-button[slot="end"].button-has-icon-only),
-::slotted(ion-input-password-toggle::part(button)) {
+::slotted(ion-button[slot="end"].button-has-icon-only) {
   --border-radius: 50%;
   --padding-start: 0;
   --padding-end: 0;

diff --git a/core/src/components/input/input.md.scss b/core/src/components/input/input.md.scss
@@ -115,8 +115,7 @@
  * don't look too crowded.
  */
 ::slotted(ion-button[slot="start"].button-has-icon-only),
-::slotted(ion-button[slot="end"].button-has-icon-only),
-::slotted(ion-input-password-toggle::part(button)) {
+::slotted(ion-button[slot="end"].button-has-icon-only) {
   --border-radius: 50%;
   --padding-start: 8px;
   --padding-end: 8px;