-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: remove hardcoded dark palette from tests (#29357)
Issue number: N/A --------- ## What is the current behavior? Dark palette is hardcoded in style tags in tests. ## What is the new behavior? Updated the following tests: - **datetime/basic** - added an import for `dark.class.css` which works with the checkbox to toggle the `ion-palette-dark` class - does not update the e2e test to include dark palette because this was not tested previously - **datetime/color** - added an import for `dark.class.css` which works with the checkbox to toggle the `ion-palette-dark` class - updates the e2e test to use the dark palette - **modal/dark-mode** - added an import for `dark.always.css` which always applies the dark palette - does not update the e2e test to include dark palette because this test needs to be moved but I am not sure where it should go yet - **toggle/enable-on-off-labels** - added an import for `dark.class.css` which works with the checkbox to toggle the `ion-palette-dark` class - updates the e2e test to use the dark palette & splits the color into a separate screenshot test Did not update the following tests: - **item/buttons** - has already been updated to remove the dark palette - **toggle/legacy/enable-on-off-labels** - test was removed in v8 ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information - We could probably remove the checkbox toggles entirely when we add support for the `palette` query param. --------- Co-authored-by: ionitron <hi@ionicframework.com>
- Loading branch information
1 parent
eb7ba23
commit 6b13e13
Showing
96 changed files
with
84 additions
and
675 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-22.7 KB
...r/datetime.e2e.ts-snapshots/datetime-color-dark-ios-ltr-Mobile-Chrome-linux.png
Binary file not shown.
Binary file removed
BIN
-27.1 KB
.../datetime.e2e.ts-snapshots/datetime-color-dark-ios-ltr-Mobile-Firefox-linux.png
Binary file not shown.
Binary file removed
BIN
-20.8 KB
...r/datetime.e2e.ts-snapshots/datetime-color-dark-ios-ltr-Mobile-Safari-linux.png
Binary file not shown.
Binary file removed
BIN
-20.6 KB
...or/datetime.e2e.ts-snapshots/datetime-color-dark-md-ltr-Mobile-Chrome-linux.png
Binary file not shown.
Binary file removed
BIN
-23.9 KB
...r/datetime.e2e.ts-snapshots/datetime-color-dark-md-ltr-Mobile-Firefox-linux.png
Binary file not shown.
Binary file removed
BIN
-17.6 KB
...or/datetime.e2e.ts-snapshots/datetime-color-dark-md-ltr-Mobile-Safari-linux.png
Binary file not shown.
Binary file modified
BIN
-558 Bytes
(98%)
.../color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Chrome-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-190 Bytes
(99%)
...color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Firefox-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-319 Bytes
(99%)
.../color/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-Mobile-Safari-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.4 KB
...r/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Chrome-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.7 KB
.../datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Firefox-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.6 KB
...r/datetime.e2e.ts-snapshots/datetime-color-ios-ltr-dark-Mobile-Safari-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-437 Bytes
(98%)
...t/color/datetime.e2e.ts-snapshots/datetime-color-md-ltr-Mobile-Chrome-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-448 Bytes
(98%)
.../color/datetime.e2e.ts-snapshots/datetime-color-md-ltr-Mobile-Firefox-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-317 Bytes
(98%)
...t/color/datetime.e2e.ts-snapshots/datetime-color-md-ltr-Mobile-Safari-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+21.2 KB
...or/datetime.e2e.ts-snapshots/datetime-color-md-ltr-dark-Mobile-Chrome-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24 KB
...r/datetime.e2e.ts-snapshots/datetime-color-md-ltr-dark-Mobile-Firefox-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+17.8 KB
...or/datetime.e2e.ts-snapshots/datetime-color-md-ltr-dark-Mobile-Safari-linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.