Skip to content

Commit

Permalink
fix(angular): ensure all NavigationExtras values are preserved when n…
Browse files Browse the repository at this point in the history
…avigating (#18468)

fixes #18469
  • Loading branch information
MarkChrisLevy authored and liamdebeasi committed Jun 10, 2019
1 parent 54bdb36 commit 7610787
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion angular/src/providers/nav-controller.ts
Expand Up @@ -202,7 +202,12 @@ export class NavController {
urlTree.fragment = options.fragment;
}

return this.router!.navigateByUrl(urlTree);
/**
* `navigateByUrl` will still apply `NavigationExtras` properties
* that do not modify the url, such as `replaceUrl` which is why
* `options` is passed in here.
*/
return this.router!.navigateByUrl(urlTree, options);
}
}
}
Expand Down

0 comments on commit 7610787

Please sign in to comment.