refactor(menu): deprecate main html attribute (#19237)

ionic-team · Oct 2, 2019 · 9688f4d · 9688f4d
1 parent f4818a1
commit 9688f4d
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx
@@ -148,6 +148,17 @@ export class Menu implements ComponentInterface, MenuI {
 
     const el = this.el;
     const parent = el.parentNode as any;
+    if (this.contentId === undefined) {
+      console.warn(`[DEPRECATED][ion-menu] Using the [main] attribute is deprecated, please use the "contentId" property instead:
+BEFORE:
+  <ion-menu>...</ion-menu>
+  <div main>...</div>
+
+AFTER:
+  <ion-menu contentId="my-content"></ion-menu>
+  <div id="my-content">...</div>
+`);
+    }
     const content = this.contentId !== undefined
       ? document.getElementById(this.contentId)
       : parent && parent.querySelector && parent.querySelector('[main]');

diff --git a/core/src/components/split-pane/split-pane.tsx b/core/src/components/split-pane/split-pane.tsx
@@ -69,6 +69,24 @@ export class SplitPane implements ComponentInterface {
     }
   }
 
+  componentWillLoad() {
+    if (this.contentId === undefined) {
+      console.warn(`[DEPRECATED][ion-split-pane] Using the [main] attribute is deprecated, please use the "contentId" property instead:
+BEFORE:
+  <ion-split-pane>
+    ...
+    <div main>...</div>
+  </ion-split-pane>
+
+AFTER:
+  <ion-split-pane contentId="main-content">
+    ...
+    <div id="main-content">...</div>
+  </ion-split-pane>
+`);
+    }
+  }
+
   @Watch('disabled')
   @Watch('when')
   protected updateState() {