Skip to content

Commit

Permalink
fix(utils/dom): do not add rAF polyfill to window
Browse files Browse the repository at this point in the history
A pull request (#1430) was merged that added a requestAnimationFrame polyfill to
the window on platforms that do not have rAF.  This was overlooked.
This now has created conflicts with Angular 1.2.17 on Android browsers
that do not have requestAnimationFrame.

The problem was that a polyfill for requestAnimationFrame was put onto the
window for Android <4.3. AngularJS would then check if
window.requestAnimationFrame existed.  Angular's check passed, and then
it would try to use cancelAnimationFrame which was undefined.

Now, nothing on the window is changed.
  • Loading branch information
ajoslin committed Jun 16, 2014
1 parent be351ce commit ae8136d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions js/utils/dom.js
Expand Up @@ -31,9 +31,6 @@
window.mozCancelAnimationFrame ||
window.webkitCancelRequestAnimationFrame;

window.requestAnimationFrame = window._rAF;
window.cancelAnimationFrame = cancelAnimationFrame;

/**
* @ngdoc utility
* @name ionic.DomUtil
Expand Down

0 comments on commit ae8136d

Please sign in to comment.