Skip to content

Commit

Permalink
refactor(react): only ship es modules (#26044)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

`@ionic/react` and `@ionic/react-router` no longer ship a CommonJS entry point. Instead, only an ES Module entry point is provided for improved compatibility with Vite.
  • Loading branch information
liamdebeasi committed Sep 30, 2022
1 parent 86bbed0 commit c946af2
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 18 deletions.
5 changes: 5 additions & 0 deletions BREAKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ This is a comprehensive list of the breaking changes introduced in the major ver
- [Textarea](#version-7x-textarea)
- [Virtual Scroll](#version-7x-virtual-scroll)
- [JavaScript Frameworks](#version-7x-javascript-frameworks)
- [React](#version-7x-react)
- [Vue](#version-7x-vue)
- [Utilities](#version-7x-utilities)
- [hidden attribute](#version-7x-hidden-attribute)
Expand Down Expand Up @@ -143,6 +144,10 @@ Any references to the virtual scroll types from `@ionic/core` have been removed.

<h2 id="version-7x-javascript-frameworks">JavaScript Frameworks</h2>

<h4 id="version-7x-react">React</h4>

`@ionic/react` and `@ionic/react-router` no longer ship a CommonJS entry point. Instead, only an ES Module entry point is provided for improved compatibility with Vite.

<h4 id="version-7x-vue">Vue</h4>

`@ionic/vue` and `@ionic/vue-router` no longer ship a CommonJS entry point. Instead, only an ES Module entry point is provided for improved compatibility with Vite.
Expand Down
1 change: 0 additions & 1 deletion packages/react-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"sync": "sh ./scripts/sync.sh"
},
"main": "dist/index.js",
"module": "dist/index.esm.js",
"types": "dist/types/index.d.ts",
"files": [
"dist/"
Expand Down
9 changes: 2 additions & 7 deletions packages/react-router/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,11 @@ import resolve from '@rollup/plugin-node-resolve';
export default {
input: 'dist-transpiled/index.js',
output: [
{
file: 'dist/index.esm.js',
format: 'es',
sourcemap: true,
},
{
file: 'dist/index.js',
format: 'commonjs',
format: 'es',
sourcemap: true,
},
}
],
external: (id) => !/^(\.|\/)/.test(id),
plugins: [resolve(), sourcemaps()],
Expand Down
1 change: 0 additions & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"sync": "sh ./scripts/sync.sh"
},
"main": "dist/index.js",
"module": "dist/index.esm.js",
"types": "dist/types/index.d.ts",
"files": [
"dist/",
Expand Down
12 changes: 3 additions & 9 deletions packages/react/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,11 @@ export default {
output: [
{
dir: 'dist/',
entryFileNames: '[name].esm.js',
chunkFileNames: '[name]-[hash].esm.js',
entryFileNames: '[name].js',
chunkFileNames: '[name]-[hash].js',
format: 'es',
sourcemap: true,
},
{
dir: 'dist/',
format: 'commonjs',
preferConst: true,
sourcemap: true,
},
}
],
external: (id) => !/^(\.|\/)/.test(id),
plugins: [
Expand Down

0 comments on commit c946af2

Please sign in to comment.