Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.15-0] Tab bar bottom safe area not expanding height #16175

Closed
sbannigan opened this issue Nov 1, 2018 · 1 comment · Fixed by #16179
Closed

[4.0.0-beta.15-0] Tab bar bottom safe area not expanding height #16175

sbannigan opened this issue Nov 1, 2018 · 1 comment · Fixed by #16179
Labels

Comments

@sbannigan
Copy link
Contributor

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.

Ionic:

   ionic (Ionic CLI)          : 4.1.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.15-0
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.2
   @angular/cli               : 6.1.2
   @ionic/ng-toolkit          : not installed
   @ionic/schematics-angular  : not installed

System:

   NodeJS : v8.11.2 (/usr/local/bin/node)
   npm    : 6.4.1
   OS     : macOS

Describe the Bug
Safe area padding on the bottom of the new ion-tab-bar does not display correctly. It adds the padding but the height of the bar does not change, shrinking the tab bar content instead:

screen shot 2018-11-01 at 10 24 20 am

Expected Behavior
Safe area padding should push the tab bar up instead of shrinking the content like so:

screen shot 2018-11-01 at 10 24 37 am

Additional Context
Was able to override this for now by using margin instead of padding:

ion-tab-bar.placement-bottom {
    padding-bottom: 0;
    margin-bottom: var(--ion-safe-area-bottom, 0px);
}

The original implementation used padding though, so I don't feel like that is a permanent fix.

@ionitron-bot ionitron-bot bot added the triage label Nov 1, 2018
manucorporat added a commit that referenced this issue Nov 1, 2018
* fix(tab-bar): safe-bottom area is applied correctly

fixes #16175

* add test
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant