Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.15] content resize method missing #16258

Closed
meta0102 opened this issue Nov 7, 2018 · 7 comments
Closed

[4.0.0-beta.15] content resize method missing #16258

meta0102 opened this issue Nov 7, 2018 · 7 comments
Labels
needs: reply the issue needs a response from the user

Comments

@meta0102
Copy link

meta0102 commented Nov 7, 2018

Bug Report

Ionic:

ionic (Ionic CLI) : 4.0.6

System:

NodeJS : v8.11.3
npm : 6.4.1
OS : Windows 10

Describe the Bug
the resize method for ion-content is missing. i need to call this method to resize the searchbar
see #7706

@ionitron-bot ionitron-bot bot added the triage label Nov 7, 2018
@brandyscarney
Copy link
Member

Thanks for the issue! In Ionic 4, the ion-content layout is based on flex. This means the size of the content will automatically adjust without the need to call resize(). I'm not able to see any issues with this and removing the toolbar. Could you please provide a way for us to reproduce if you're seeing issues with this? Thanks!

@brandyscarney brandyscarney added the needs: reply the issue needs a response from the user label Nov 7, 2018
@ionitron-bot ionitron-bot bot removed the triage label Nov 7, 2018
@meta0102
Copy link
Author

meta0102 commented Nov 7, 2018

hi, sure.
the problem appears only on big screens, on mobile width all looks fine

<ion-header no-border>
  <ion-toolbar class="transparent-toolbar">
    <ion-buttons slot="end">
      <ion-button *ngIf="!showSearchBar" icon-only (click)="presentSearch()">
        <ion-icon class="md-icon" name="search"></ion-icon>
      </ion-button>
    </ion-buttons>
    <ion-title *ngIf="!showSearchBar">{{title}}</ion-title>
    <ion-searchbar showCancelButton *ngIf="showSearchBar" placeholder="Suchen" (ionClear)="onSearchCancel($event)" [(ngModel)]="searchstring" (search)="search()"></ion-searchbar>
  </ion-toolbar>
</ion-header>

<ion-content fullscreen>
</ion-content>


presentSearch() {
      this.showSearchBar = true;
}
onSearchCancel() {
      this.showSearchBar = false;
      this.searchstring = '';
}
search() {

}

thanks

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Nov 7, 2018
@peterpeterparker
Copy link
Contributor

I think resize is not needed anymore in v4, duplicate #14875

@ghost
Copy link

ghost commented Nov 24, 2018

@peterpeterparker, Why you think resize is not needed anymore in v4? If not needed, than why scrollToBottom not working correctly, when content comes dynamycaly? I found your comment, where you wrote about resize() #14875 (comment). I use resize() in my chat app too, like this:
this.content.resize();
this.content.scrollToBottom(0);.
I think will be better way to run resize() method on all scroll methods.
Thank you.

@peterpeterparker
Copy link
Contributor

@bossjon because I used to use it in v3 but don't use it anymore in v4, even in pages where I use scrollToBottom with dynamic content aka in my chat

@brandyscarney
Copy link
Member

I tried to reproduce the problem using the code above but I am not seeing any issues with content where it would need to be resized. If anyone could please provide code that I can use to reproduce this or confirm it is no longer an issue that would be great. Thank you!!

Codepen: https://codepen.io/brandyscarney/pen/GeoazQ?editors=1010

@brandyscarney brandyscarney added needs: reply the issue needs a response from the user and removed needs: investigation labels Mar 1, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Mar 31, 2019

Thanks for the issue! This issue is being closed due to the lack of a reply. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Mar 31, 2019
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants