Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add a border to fab-button #16652

Closed
Maistho opened this issue Dec 10, 2018 · 4 comments
Closed

Cannot add a border to fab-button #16652

Maistho opened this issue Dec 10, 2018 · 4 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@Maistho
Copy link
Contributor

Maistho commented Dec 10, 2018

Bug Report

Ionic version:

[x] 4.x

Current behavior:
Cannot add a border or change the border-radius of fab-button

Expected behavior:
Can add a border or change the border-radius, as the documentation states is possible.

Steps to reproduce:

ion-fab-button {
  --border-radius: 10px;
  --border-color: white;
  --border-width: 4px;
  --border-style: solid;
}

Related code:
This line sets border to be zero, not taking the custom properties in account: https://github.com/ionic-team/ionic/blob/master/core/src/components/fab-button/fab-button.scss#L94

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.5.0 (/home/maistho/.config/yarn/global/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.17
   @angular-devkit/build-angular : 0.11.2
   @angular-devkit/schematics    : 7.1.2
   @angular/cli                  : 7.1.2
   @ionic/angular-toolkit        : 1.2.0

Cordova:

   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms     : browser 5.0.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.3.1, (and 5 other plugins)

System:

   NodeJS : v10.14.1 (/usr/bin/node)
   npm    : 6.4.1
   OS     : Linux 4.19

@ionitron-bot ionitron-bot bot added the triage label Dec 10, 2018
@paulstelzer paulstelzer added package: core @ionic/core package type: bug a confirmed bug report and removed triage labels Dec 10, 2018
@paulstelzer
Copy link
Contributor

Thanks for your issue! You are right, the CSS variables are in the documentation, but not integrated yet. I think this is something for @brandyscarney :)

@Maistho
Copy link
Contributor Author

Maistho commented Dec 10, 2018

If that's OK, I can open a PR in order to get this fixed sooner. Already have it fixed on my fork. 🙂

@paulstelzer
Copy link
Contributor

That would be the best way :)

@ionitron-bot
Copy link

ionitron-bot bot commented Jan 9, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants