Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: content is not getting proper offset-top on load #20735

Closed
brandyscarney opened this issue Mar 10, 2020 · 2 comments
Closed

bug: content is not getting proper offset-top on load #20735

brandyscarney opened this issue Mar 10, 2020 · 2 comments
Assignees
@liamdebeasi
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone
5.0.6

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Mar 10, 2020 •
edited

Bug Report

Ionic version:

[x] 5.x

Current behavior:

On initial load of a page in a Stencil app, the content offset-top is not being set properly which is causing bugs with the swipe to close modal & theming. After navigating around and back to the page, it is set properly. You can reproduce it on this PR: ionic-team/ionic-stencil-conference-app#391

  1. Opening the swipe to close modal by pressing the upper right button, notice the header becomes a black background

  1. Setting dark mode in the side menu, notice the header is white

Navigate around the app and try to reproduce it.
@brandyscarney brandyscarney added package: core @ionic/core package type: bug a confirmed bug report labels Mar 10, 2020
@brandyscarney brandyscarney mentioned this issue Mar 10, 2020
Merged
@liamdebeasi
Copy link
Member

Possibly related to #20614

@liamdebeasi liamdebeasi self-assigned this Mar 13, 2020
This was referenced Mar 14, 2020
Merged
Closed
@liamdebeasi liamdebeasi mentioned this issue Mar 16, 2020
Merged
13 tasks
@liamdebeasi liamdebeasi added this to the 5.0.6 milestone Mar 16, 2020
@liamdebeasi liamdebeasi reopened this Mar 19, 2020
liamdebeasi added a commit that referenced this issue Mar 25, 2020
@liamdebeasi
fix(content): apply --offset-top and --offset-bottom values correctly (…
2707289 
…#20790)

fixes #20735
@ionitron-bot
Copy link

ionitron-bot bot commented Apr 23, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liamdebeasi liamdebeasi

Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
5.0.6
Development

No branches or pull requests
2 participants
@liamdebeasi @brandyscarney