fix(modal): backdropBreakpoint allows interactivity behind sheet #24798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #24797
backdropBreakpoint partially only worked by chance, so the moment we changed something related to backdrop, this broke. We did not catch it because our test coverage for interacting with the backdrop is pretty minimal.
pointer-events: none
to the backdrop so you cannot accidentally dismiss the modal while it is entering. Because we callprogressStart
on the sheet animation,pointer-events: none
was always added to the backdrop so you could never interact with it.What is the new behavior?
Does this introduce a breaking change?
Other information