Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scroll-assist): touch end events continue to bubble on inputs #25282

Merged
merged 5 commits into from
May 16, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25229

There are two issues here:

  1. The first time that you tap an ion-input, the touchend event never fires.
  2. If you focus an input then quickly swipe to go back, the swipe to go back gesture can get stuck.

Both of these issues are happening because of the follow code: https://github.com/ionic-team/ionic-framework/blob/main/core/src/utils/input-shims/hacks/scroll-assist.ts#L30

stopPropagation prevents an event from bubbling. So when we call stopPropagation, the touchend event does not bubble up and the swipe gesture never completes. The gesture util listens for touchend to know when to fire the onEnd callback: https://github.com/ionic-team/ionic-framework/blob/main/core/src/utils/gesture/pointer-events.ts#L43

What is the new behavior?

  • This PR removes the stopPropagation code to allow the touchend event to continue to bubble. This fixes both issues.

I fixed a similar issue in 2021 where the click event was being suppressed in the same area: f7d4c21

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 12, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review May 13, 2022 13:03
@liamdebeasi liamdebeasi requested a review from a team as a code owner May 13, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: scroll assist calls stopPropagation which can cause swipe to go back to break
2 participants