Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): rtl menu no longer disappears on ios 15.4+ #25309

Merged
merged 5 commits into from
May 19, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 18, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25192

There is a bug in the CSS Containment implementation in WebKit where focusing elements after an animation in RTL will cause the element to disappear.

When you open ion-menu, we focus the container element. Browsers such as WebKit will attempt to focus the first focusable element inside of ion-menu. When this happens, the WebKit bug kicks in and the menu disappears.

For some reason, this only happens when the animated element is translated using a translate3d. Using a 2d transform does not reproduce the issue.

Our translate3d usage here was added back in Ionic v3: ionic-team/ionic-v3@b31ab1b

At the time, translate3d was usually needed to force the browser to use hardware acceleration when animating the menu. This is no longer needed, and we are forcing the browser to do additional work when it does not need to.

What is the new behavior?

  • Replaced translate3d with a translateX for the.menu-inner element.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.1.6-dev.11652891005.1ac88bcc

@github-actions github-actions bot added the package: core @ionic/core package label May 18, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review May 18, 2022 16:31
@liamdebeasi liamdebeasi requested a review from a team as a code owner May 18, 2022 16:31
@liamdebeasi liamdebeasi requested review from averyjohnston and sean-perkins and removed request for a team May 18, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ios, menu disappears on rtl mode when focusing element in menu
3 participants