Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: navigation inside of ion nav is buggy #25677

Closed
4 of 7 tasks
EinfachHans opened this issue Jul 26, 2022 · 6 comments · Fixed by #25689
Closed
4 of 7 tasks

bug: navigation inside of ion nav is buggy #25677

EinfachHans opened this issue Jul 26, 2022 · 6 comments · Fixed by #25689
Assignees
Labels

Comments

@EinfachHans
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

Navigation in a <ion-nav> inside a Modal appears to be very buggy for me:

  1. The IonTitle of the root page animates wrong -> To the bottom of the side
  2. The entering of the next page is buggy and stucks a short time in the animation

Expected Behavior

The animation should work without bugs 😃

Steps to Reproduce

See attached Repo:

  1. Open Modal
  2. Navigate forward (buggy enter animation)
  3. Navigate back via click or swipe (buggy leave animation)

Code Reproduction URL

https://github.com/EinfachHans/ionic-modal-nav-bug

Ionic Info

Ionic:

Ionic CLI : 6.20.1 (/Users/hans/.nvm/versions/node/v16.14.2/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.1.15
@angular-devkit/build-angular : 14.1.0
@angular-devkit/schematics : 14.1.0
@angular/cli : 14.1.0
@ionic/angular-toolkit : 6.1.0

Capacitor:

Capacitor CLI : 3.6.0
@capacitor/android : not installed
@capacitor/core : 3.6.0
@capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.15.1
native-run : 1.6.0

System:

NodeJS : v16.14.2 (/Users/hans/.nvm/versions/node/v16.14.2/bin/node)
npm : 8.6.0
OS : macOS Monterey

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jul 26, 2022
@sean-perkins sean-perkins self-assigned this Jul 27, 2022
@sean-perkins
Copy link
Contributor

@EinfachHans thanks for reporting this issue!

This appears to work in 6.1.14, but broke in 6.1.15. We will classify this as a bug and figure out what caused the regression.

@sean-perkins
Copy link
Contributor

@EinfachHans If you update your example template for modal.component.html to:

<ion-content>
  <ion-nav [root]="root"></ion-nav>
</ion-content>

This will solve the problem in your project. The change to support custom sized dialogs affects implementations of modal that don't use ion-content. Discussing with the team of the best options here. Ideally we would like to recommend developers use the template sample provided above when using ion-nav in a modal, but this may also cause issues with existing applications built without it.

@liamdebeasi
Copy link
Contributor

Here is a dev build if you would like to test the fix: 6.1.16-dev.11658962095.1f24647d

@EinfachHans
Copy link
Contributor Author

Works, thank you! 😊

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #25689, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 27, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants