Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav): exclude nav from custom dialog #25689

Merged
merged 3 commits into from Jul 28, 2022
Merged

fix(nav): exclude nav from custom dialog #25689

merged 3 commits into from Jul 28, 2022

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Jul 27, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25688, resolves #25677

The issue was caused by this commit: a6f3ae6

We targeted ion-modal .ion-page but did not consider that .ion-page is also used inside of ion-nav. As a result, this changed the styles for pages in ion-nav and broke page transitions.

We also considered just doing ion-modal > .ion-page, but there is an existing issue where multiple .ion-page elements can be appended on subsequent modal presentations. The fix for that will take some time, so we opted to exclude ion-nav from the .ion-page changes for now.

What is the new behavior?

  • pages in ion-nav are now excluded from the custom dialog changes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 27, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review July 28, 2022 14:01
@liamdebeasi liamdebeasi requested a review from a team as a code owner July 28, 2022 14:01
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-nav transitions are broken in react bug: navigation inside of ion nav is buggy
3 participants