fix(menu): allow styling of the box shadow and transform when visible inside of a split pane #28691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
requested review from
a team and
sean-perkins
and removed request for
a team
brandyscarney
requested review from
amandaejohnston and
a team
as code owners
liamdebeasi
requested review from
liamdebeasi
and removed request for
sean-perkins
liamdebeasi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #21530
What is the current behavior?
The
box-shadowandtransformproperties cannot be styled on a menu when it is inside of a split pane and visible due to the following:box-shadowandtransformproperties are set tononewith!importantWhat is the new behavior?
!importantin split pane and menuz-indexfrom0to1on theion-menuso the menu will sit on top of the split pane and show thebox-shadowDoes this introduce a breaking change?
Other information
I considered putting the test for this in
split-panebut I thought since it was styling theion-menuit should go in menu. I can move this if others think it makes more sense insplit-pane.