Skip to content

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 11, 2023

Issue number: resolves #21530


What is the current behavior?

The box-shadow and transform properties cannot be styled on a menu when it is inside of a split pane and visible due to the following:

  1. The box-shadow and transform properties are set to none with !important
  2. The menu itself is not on "top" of the split pane content so the content hides any box shadow

What is the new behavior?

  • Removes all uses of !important in split pane and menu
  • Developers will need to change the z-index from 0 to 1 on the ion-menu so the menu will sit on top of the split pane and show the box-shadow

Does this introduce a breaking change?

  • Yes
  • No

Other information

I considered putting the test for this in split-pane but I thought since it was styling the ion-menu it should go in menu. I can move this if others think it makes more sense in split-pane.

@github-actions github-actions bot added the package: core @ionic/core package label Dec 11, 2023
@brandyscarney brandyscarney marked this pull request as ready for review December 12, 2023 15:15
@brandyscarney brandyscarney requested review from a team and sean-perkins and removed request for a team December 12, 2023 15:16
@brandyscarney brandyscarney requested review from a team and averyjohnston as code owners December 12, 2023 15:16
@liamdebeasi liamdebeasi requested review from liamdebeasi and removed request for sean-perkins December 12, 2023 16:54
@brandyscarney brandyscarney added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 8ee23d2 Dec 12, 2023
@brandyscarney brandyscarney deleted the FW-5572 branch December 12, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: cannot set box-shadow on menu when split pane is visible

3 participants