Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Popover arrow is rendered under the backdrop #28985

Closed
3 tasks done
sean-perkins opened this issue Jun 2, 2023 · 6 comments · Fixed by #28986
Closed
3 tasks done

bug: Popover arrow is rendered under the backdrop #28985

sean-perkins opened this issue Jun 2, 2023 · 6 comments · Fixed by #28986
Assignees
Labels
type: bug a confirmed bug report

Comments

@sean-perkins
Copy link
Contributor

sean-perkins commented Jun 2, 2023

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

This issue only seems to reproduce on Mac

As seen in the Side and Alignment Demo, when the popover is presented in iOS the arrow is lighter than the popover container as a result of rendering under the backdrop.

CleanShot 2023-06-02 at 12 16 36

Additionally, while hard to visibly see based on the background color, the arrow is not tight to the container and is ~1px offset from where it should render.

Expected Behavior

  1. The popover arrow should have the same visible background state as the popover container. With brief exploration, the z-index of .popover-arrow should be 11 or greater.
  2. The popover arrow should be tight to the container, as seen in the Human Interface Guidelines. With brief exploration, the fractional units used for the top value are causing the arrow to render incorrectly. Flooring the value results in the correct display.

Here is a modified example of the expected visual state:
CleanShot 2023-06-02 at 12 22 25

Steps to Reproduce

  1. Visit the Side and Alignment Demo
  2. With iOS active, Click "Side=Top, Alignment=Center" button
  3. Observe: The arrow for the presented popover is not the same background color as the popover container.
  4. Observe: The arrow is offset from the container.

Code Reproduction URL

No response

Ionic Info

N/A

Additional Information

Tested on Google Chrome: Version 113.0.5672.126 (Official Build) (arm64)

This issue is not captured in our visual regression tests: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Chrome-linux.png

@ionitron-bot ionitron-bot bot added the triage label Jun 2, 2023
@thetaPC
Copy link
Contributor

thetaPC commented Jun 2, 2023

Thank you for the issue! I was able to replicate it using Firefox, Chrome, and Safari with a Mac.

@ionitron-bot ionitron-bot bot removed the triage label Jun 2, 2023
@thetaPC thetaPC added the triage label Jun 2, 2023
@ionitron-bot ionitron-bot bot removed the triage label Jun 2, 2023
@Sahil-B07
Copy link
Contributor

Hi, I would like to work on this issue 🙂

@thetaPC
Copy link
Contributor

thetaPC commented Feb 5, 2024

Update: I have verified that this issue is not being replicated within Ionic Framework. It's only happening within the Ionic docs site.

@thetaPC thetaPC transferred this issue from ionic-team/ionic-framework Feb 5, 2024
@ionitron-bot ionitron-bot bot added triage and removed triage labels Feb 5, 2024
@thetaPC thetaPC transferred this issue from ionic-team/ionic-docs Feb 6, 2024
@ionitron-bot ionitron-bot bot added the triage label Feb 6, 2024
@thetaPC thetaPC assigned thetaPC and unassigned mapsandapps Feb 6, 2024
@thetaPC
Copy link
Contributor

thetaPC commented Feb 6, 2024

After discussing with the team, the issue indeed lies within the Ionic Framework.

@thetaPC thetaPC added the type: bug a confirmed bug report label Feb 6, 2024
@ionitron-bot ionitron-bot bot removed the triage label Feb 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2024
Issue number: resolves #28985

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

When a popover is being rendered in iOS mode, the arrow renders under
the backdrop.

![Screenshot 2024-02-06 at 11 59
58 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/b55f8868-4de3-4f52-8e79-650a40f8d5bd)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The arrow renders at the same level as the content.

![Screenshot 2024-02-06 at 11 59
51 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/05c214ee-6ba7-4cad-b00e-9668dca23f73)

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the
[fix](#28430). A new
PR had to be created in order to update snapshots.

---------

Co-authored-by: Sahil Bhor <92709590+Sahil-B07@users.noreply.github.com>

---------

Co-authored-by: ionitron <hi@ionicframework.com>
liamdebeasi pushed a commit that referenced this issue Feb 7, 2024
Issue number: resolves #28985

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

<!-- Please describe the current behavior that you are modifying. -->

When a popover is being rendered in iOS mode, the arrow renders under
the backdrop.

![Screenshot 2024-02-06 at 11 59
58 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/b55f8868-4de3-4f52-8e79-650a40f8d5bd)

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The arrow renders at the same level as the content.

![Screenshot 2024-02-06 at 11 59
51 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/05c214ee-6ba7-4cad-b00e-9668dca23f73)

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the
[fix](#28430). A new
PR had to be created in order to update snapshots.

---------

Co-authored-by: Sahil Bhor <92709590+Sahil-B07@users.noreply.github.com>
Co-authored-by: ionitron <hi@ionicframework.com>
@thetaPC
Copy link
Contributor

thetaPC commented Feb 7, 2024

Thanks for the issue! This has been resolved via #28986 and will be available in an upcoming release of Ionic.

Copy link

ionitron-bot bot commented Mar 8, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug a confirmed bug report
Projects
None yet
4 participants