Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item slot end is shifted to the left #29033

Closed
3 tasks done
robingenz opened this issue Feb 13, 2024 · 5 comments · Fixed by #29036
Closed
3 tasks done

bug: ion-item slot end is shifted to the left #29033

robingenz opened this issue Feb 13, 2024 · 5 comments · Fixed by #29036
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@robingenz
Copy link
Contributor

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

After I updated to Ionic 7.7.1, it looked like this:

111-after

Expected Behavior

With Ionic 7.5.0 it looked like this:

111-before

That is also the behavior I expect.

Steps to Reproduce

Simply use the following code:

<ion-list>
	<ion-item>
		<ion-label>Start</ion-label>
		<ion-label slot="end">End</ion-label>
	</ion-item>
</ion-list>

Code Reproduction URL

https://codepen.io/robingenz/pen/XWGyBQz

Ionic Info

Ionic:

   Ionic CLI                     : 7.1.6
   Ionic Framework               : @ionic/angular 7.7.1
   @angular-devkit/build-angular : 17.0.8
   @angular-devkit/schematics    : 16.2.8
   @angular/cli                  : 17.0.8
   @ionic/angular-toolkit        : 10.0.0

Capacitor:

   Capacitor CLI      : 5.6.0
   @capacitor/android : 5.6.0
   @capacitor/core    : 5.6.0
   @capacitor/ios     : 5.6.0

Utility:

   cordova-res                          : not installed globally
   native-run (update available: 2.0.1) : 2.0.0

System:

   NodeJS : v18.19.0 (/opt/homebrew/Cellar/node@18/18.19.0/bin/node)
   npm    : 10.2.3
   OS     : macOS Unknown

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Looks like this is an edge case I missed from #28769. I'll get a PR up to fix.

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Feb 13, 2024
@ionitron-bot ionitron-bot bot removed the triage label Feb 13, 2024
@liamdebeasi
Copy link
Contributor

Here's a dev build if you are interested in testing a fix: 7.7.2-dev.11707840956.16e27b4c

@liamdebeasi liamdebeasi removed their assignment Feb 13, 2024
@robingenz
Copy link
Contributor Author

Thank you for this fast fix! I've just tested it and it looks good!

github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2024
Issue number: resolves #29033

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

In #28773 I resolved
several incorrect behaviors with Items related to text wrapping.
However, it looks like I missed the removal of
https://github.com/ionic-team/ionic-framework/pull/28146/files#diff-4a1156704dbf45b0dad273b6909b190ca45e4380aa7378ba88d0dd7d48d7d473R37
which caused the issue to persist when adding a label to the end slot.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed logic that caused `ion-label` to grow larger than it needed to
be

| `main` | branch |
| - | - |
| ![Screenshot 2024-02-13 at 11 20
43 AM](https://github.com/ionic-team/ionic-framework/assets/2721089/3fbddd04-d4b5-474c-ab9c-4d9c6e88f758)
| ![Screenshot 2024-02-13 at 11 21
17 AM](https://github.com/ionic-team/ionic-framework/assets/2721089/188eda24-ec6f-4ba7-b3ed-2993d93b1cc7)
|

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: `7.7.2-dev.11707840956.16e27b4c`

---------

Co-authored-by: ionitron <hi@ionicframework.com>
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #29036, and a fix will be available in an upcoming release of Ionic Framework.

Copy link

ionitron-bot bot commented Mar 15, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants