Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Service #5426

Closed
7 tasks done
adamdbradley opened this issue Feb 11, 2016 · 15 comments
Closed
7 tasks done

Loading Service #5426

adamdbradley opened this issue Feb 11, 2016 · 15 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.4

Comments

@adamdbradley
Copy link
Contributor

@adamdbradley adamdbradley self-assigned this Feb 11, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.7 milestone Feb 11, 2016
@imsingh
Copy link

imsingh commented Feb 12, 2016

@adamdbradley are you referring to $ionicLoading for v2. I was searching for either Loading Service or Spinner for v2. But they are not available yet right?

@privetr
Copy link

privetr commented Mar 4, 2016

This would be a good new feature !

@susanlinsfu
Copy link

This would be great! Simple feature, but from a UX perspective very useful!

@EuAndreh
Copy link

There's a good tutorial on how to create a custom one:

http://www.joshmorony.com/how-to-create-a-custom-loading-component-in-ionic-2/

I believe it solves most needs.

@brandyscarney brandyscarney self-assigned this Mar 24, 2016
brandyscarney added a commit that referenced this issue Mar 28, 2016
@brandyscarney
feat(loading): add loading indicator component and styles
a485cd0 
this is the initial commit - still needs work

references #5426
brandyscarney added a commit that referenced this issue Apr 1, 2016
@brandyscarney
feat(loading): add ability to hide spinner in the config or options
dae37e7 
tweak css to add a max width to the loading indicator

references #5426
brandyscarney added a commit that referenced this issue Apr 1, 2016
@brandyscarney
docs(demos): add API demos for loading indicator
3bce7ba 
references #5426
brandyscarney added a commit that referenced this issue Apr 1, 2016
@brandyscarney
docs(loading): remove the enableBackdropDismiss and update demo
d21a682 
references #5426
@thiphariel
Copy link

Hi. The current ionic-native SpinnerDialog will not be used for this service right ? It looks kinda wrong on iOS, hope it's jsut a temporary thing :)

@brandyscarney
Copy link
Member

@thiphariel This loading service will not use the SpinnerDialog plugin. It's custom UI that uses the Ionic spinners. You will be able to use any of our spinners or custom content. Here's a sneak peek of the UI for the default spinners:

loading-modes

@thiphariel
Copy link

@brandyscarney yeaap ! Thanks for the screens, looks awesome. Btw, it's for which beta ?

@brandyscarney
Copy link
Member

@thiphariel We're planning on releasing it with beta.4! 😄

@thiphariel
Copy link

@brandyscarney Yihaaa :D nice nice nice ! Hope it will coming soon ! Thanks

@hlehmann
Copy link

hlehmann commented Apr 4, 2016

Very cool ! Any estimation of when this beta will be release ?

@brandyscarney
Copy link
Member

@hlehmann @thiphariel Check out the milestones to see where we're at with each beta. 😄 We have a few issues open on beta.4 but at the very least we want to complete #5418, #6026 and this issue before releasing beta.4.

brandyscarney added a commit that referenced this issue Apr 5, 2016
@brandyscarney
docs(demos): update loading indicator demo and e2e
f096cf6 
references #5426
brandyscarney added a commit that referenced this issue Apr 5, 2016
@brandyscarney
feat(loading): add internal stack for the loading service
d3fa29f 
this allows the user to push multiple loading indicators on top of each
other without interfering with the page stack, as well as navigation
between pages behind the loading indicator.

references #5426
@privetr
Copy link

privetr commented Apr 5, 2016

Woo this looks great :)

@EuAndreh
Copy link

EuAndreh commented Apr 5, 2016

Awesome @brandyscarney!

Even better that beta.4 will already include it =]

brandyscarney added a commit that referenced this issue Apr 5, 2016
@brandyscarney
test(loading): add e2e test for loading in tabs and remove animation …
41a6524 
…for basic e2e

references #5426
brandyscarney added a commit that referenced this issue Apr 5, 2016
@brandyscarney
fix(loading): fix animation for loading the first time
6cd90ee 
references #5426
brandyscarney added a commit that referenced this issue Apr 5, 2016
@brandyscarney
test(karma): add karma tests for the present/zIndex of a portal
5cb319f 
references #5426
@brandyscarney
Copy link
Member

This is complete! It will be in the beta.4 release. Thanks everyone for the feedback! We'll have the API docs for this published soon.

@thiphariel
Copy link

\o/ hooray !

88% reached, great :)

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.4
Development

No branches or pull requests
8 participants
@adamdbradley @imsingh @EuAndreh @thiphariel @hlehmann @brandyscarney @privetr @susanlinsfu