Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default toolbar button color should use the inverse of the background #6364

Closed
brandyscarney opened this issue Apr 28, 2016 · 0 comments
Closed

The default toolbar button color should use the inverse of the background #6364

brandyscarney opened this issue Apr 28, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.7

Comments

@brandyscarney
Copy link
Member

Right now it will use #424242 even if you set the default background to a dark color.

$bar-button-md-color:                    $toolbar-md-button-color !default;

Should be using color-contrast
@brandyscarney brandyscarney self-assigned this Apr 28, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.7 milestone Apr 28, 2016
brandyscarney added a commit that referenced this issue May 5, 2016
@brandyscarney
fix(toolbar): md mode use the color contrast for toolbar button/title
9f54f16 
BREAKING CHANGES:

`$toolbar-md-button-color` no longer gets passed to the function that
sets the contrast color for toolbar buttons, but it can still be used
to set the default button color.

`$bar-button-md-color` was renamed to `$toolbar-md-button-color`
`$bar-button-md-border-radius` was renamed to
`$toolbar-md-button-border-radius`

references #6364
brandyscarney added a commit that referenced this issue May 5, 2016
@brandyscarney
fix(toolbar): remove color change from outline buttons in toolbar
6759074 
add color to ripple for outline buttons in toolbar

references #6364
brandyscarney added a commit that referenced this issue May 10, 2016
@brandyscarney
fix(toolbar): wp get title/button color from the contrast of toolbar …
62bd13b 
…background

BREAKING CHANGES:

`$bar-button-wp-color` was renamed to `$toolbar-wp-button-color`
`$bar-button-wp-border-radius` was renamed to
`$toolbar-wp-button-border-radius`

Added `$toolbar-wp-title-text-color` for better control of the title
color

Removed `$toolbar-wp-button-color` from the default themes

references #6364
brandyscarney added a commit that referenced this issue May 10, 2016
@brandyscarney
fix(toolbar): set the text color of the toolbar based on the contrast…
74afc18 
… of the background

BREAKING CHANGES:

`$bar-button-ios-color` has been renamed to `$toolbar-ios-button-color`
`$bar-button-ios-border-radius` has been renamed to
`$toolbar-ios-button-border-radius`

added variables for the toolbar ios title for easier styling:

```
$toolbar-ios-title-font-weight
$toolbar-ios-title-text-align
$toolbar-ios-title-text-color
```

references #6364
brandyscarney added a commit that referenced this issue May 10, 2016
@brandyscarney
test(toolbar): fix the contact icon in the e2e test
90d4c1d 
references #6364
brandyscarney added a commit that referenced this issue May 10, 2016
@brandyscarney
fix(toolbar): add the mode to the inverse function for a toolbar
3ca3027 
Use the mode instead of the sass variable to determine which color the
buttons in a toolbar should be based on the background color. Added
error messages when anything other than a color is passed and more
comments.

BREAKING CHANGES: ios mode `$toolbar-ios-button-color` now has a
default value of `color-contrast($colors-ios, $toolbar-ios-background,
ios)` which will evaluate to the primary color for light background
toolbars and white for dark background toolbars.

fixes #6364
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.7
Development

No branches or pull requests
1 participant
@brandyscarney