Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu swiping mess (push and reveal only) #6826

Closed
manucorporat opened this issue Jun 9, 2016 · 0 comments
Closed

Menu swiping mess (push and reveal only) #6826

manucorporat opened this issue Jun 9, 2016 · 0 comments
Assignees
Milestone

Comments

@manucorporat
Copy link
Contributor

manucorporat commented Jun 9, 2016

Short description of the problem:

jun-09-2016 15-43-52

This happens because both menus are capturing the sliding events at the same time.

Just in case, this bug was not caused by 29791f8

menu canStart, left isOpen false angle 0 distance 18
menu gesture, onSlideBeforeStart left
keyboard close()
menu canStart, right isOpen true angle 0 distance 18
menu gesture, onSlideBeforeStart right
keyboard close()
menu gesture, onSlide left distance 10 min 0 max 304 z 304 stepValue 0.03289473684210526
menu gesture, onSlide right distance -294 min -304 max 0 z -304 stepValue 0.9671052631578947
Menu is being dragged 0.03289473684210526
menu gesture, onSlide left distance 21 min 0 max 304 z 304 stepValue 0.06907894736842106
menu gesture, onSlide right distance -283 min -304 max 0 z -304 stepValue 0.930921052631579
Menu is being dragged 0.06907894736842106
menu gesture, onSlide left distance 31 min 0 max 304 z 304 stepValue 0.10197368421052631
menu gesture, onSlide right distance -273 min -304 max 0 z -304 stepValue 0.8980263157894737
Menu is being dragged 0.10197368421052631
(....)

Overlay menus are not affected because they use the backdrop component and it prevents the other menu from capturing the events. Using a backdrop always (a transparent one) could be a potential fix.

Another option is to get access to the MenuController from the GestureController, so we know if there are more menus opened.
@adamdbradley what do you think? I like the MenuController solution, but it sounds like a very coupled logic...

Steps to reproduce:

  1. Open a /dist/e2e/menu/basic
  2. Simulate a narrow screen (iPhone)
  3. Open a right menu
  4. Now try to open the left menu

Which Ionic Version? 2.x

@manucorporat manucorporat self-assigned this Jun 9, 2016
@manucorporat manucorporat added v2 and removed keyboard labels Jun 9, 2016
@jgw96 jgw96 added this to the 2.0.0-beta.10 milestone Jun 9, 2016
@manucorporat manucorporat mentioned this issue Jun 27, 2016
12 tasks
@jgw96 jgw96 modified the milestones: 2.0.0-beta.11, 2.0.0-beta.10 Jun 27, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jul 13, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jul 16, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants