Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidKeyboardFix fires even if keyboard is not opened #726

Closed
oinegue opened this issue Mar 5, 2014 · 4 comments
Closed

androidKeyboardFix fires even if keyboard is not opened #726

oinegue opened this issue Mar 5, 2014 · 4 comments
Assignees
Milestone

Comments

@oinegue
Copy link

oinegue commented Mar 5, 2014

I have an app with tabs and I just added this AdMob plugin.
When banner view is created, phonegap webview is shortened and androidKeyboardFix fires even if keyboard isn't opened, hiding footer and my tab bar.
As a workaround I added a timeout that remove the hide-footer class from body:

setTimeout(function(){
document.body.classList.remove('hide-footer');
},1000);

But I think this should be handled in a different way.

@oinegue oinegue closed this as completed Mar 5, 2014
@oinegue oinegue reopened this Mar 5, 2014
@adamdbradley adamdbradley added this to the 1.0 Beta2 milestone Mar 5, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Mar 19, 2014

hmm.. Not sure how we'd work around this. I will look again into using the actual keyboard events given by cordova; I didn't use those before because they were worse for some reason.

@adamdbradley
Copy link
Contributor

I just pushed a large tap refactor to solve many of these issues:
https://github.com/driftyco/ionic/blob/master/test/unit/angular/service/tap.unit.js#L4

Would you be able to test the nightly build (1712 or later) and let us know if it solved this issue?
http://code.ionicframework.com/#nightly

Thanks

Related: #862 #740 #726 #691 #689 #365 #26 #1134 #1120 #1105 #1078 #772 #745

@adamdbradley
Copy link
Contributor

Closed from ae3318a

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants