Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals without ion-nav, lifecycle events #8616

Closed
manucorporat opened this issue Oct 10, 2016 · 1 comment
Closed

Modals without ion-nav, lifecycle events #8616

manucorporat opened this issue Oct 10, 2016 · 1 comment
Assignees

Comments

@manucorporat
Copy link
Contributor

manucorporat commented Oct 10, 2016

Short description of the problem:

Modals open an alert when they are presented:

  ionViewDidEnter() {
    console.log('ModalFirstPage ionViewDidEnter fired');
    let alert = this.alertCtrl.create({
      title: 'Test',
      buttons: [
          {
              text: 'Something',
              role: 'cancel'
          }
      ]
    });
    alert.present();
  }

First modal has a child ion-nav and it works great, the alert is presented and dismissed. Instead, the second modal does not have a child ion-nav, when the alert is dismissed, the modal's ionViewDidEnter() lifecycle event is called again, presenting a new alert (entering in an infinite loop).

oct-10-2016 18-22-56

What behavior are you expecting?

Presenting or dismissing and alert should not trigger any modal's lifecycle event.

Ionic RC0

manucorporat added a commit that referenced this issue Oct 10, 2016
@jgw96 jgw96 added the v2 label Oct 10, 2016
@manucorporat manucorporat self-assigned this Oct 10, 2016
@manucorporat
Copy link
Contributor Author

Another issues related with modal not having a ion-nav:
#8631
#8616
#8597
#8437
#7580
#8151

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants