Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sass): separate sass variables from styles #13547

Merged
merged 3 commits into from Nov 30, 2017

Conversation

brandyscarney
Copy link
Member

Short description of what this resolves:

Separates sass variables from styles for all components

Changes proposed in this pull request:

  • Adds *.var.scss files for all components
  • Adds support for avatar as a stand alone component
  • Adds avatar test
  • Removes deprecated variables

Ionic Version: 4.x

Fixes: closes #9192 closes #12880

@brandyscarney brandyscarney merged commit 11c954b into core Nov 30, 2017
@brandyscarney brandyscarney deleted the core-separate-sass branch November 30, 2017 15:30
@brandyscarney
Copy link
Member Author

Here are the remaining files that include variables but don't end in *.vars.scss:

screen shot 2017-11-30 at 10 28 18 am

@ix-xerri
Copy link

What is the best way to use mixins in Ionic 4? I would like to have globally and not import the mixins file where they are used. I've tried editing angular.json, global.scss and variables.scss but no luck. Error is always thrown that the mixins are not initialised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants