feat(): Add animation on skeleton text #14068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Design related PR needs approval from @bensperry, but I will give it a try!
Thanks for the PR!
| render () { | ||
| return <span style={{width: this.width}}> </span>; | ||
| return <span style={{width: this.width}} class={this.animated ? 'animated' : ''}> </span>; |
There was a problem hiding this comment.
Class should be like this:
class={'animated': this.animated}
There was a problem hiding this comment.
I see.. Thanks for the review, that looks cleaner :) ill update the PR later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The animation gives you a feeling of progress and is something i miss in this component.
Changes proposed in this pull request: